Site icon API Security Blog

XWiki Platform Attachment UI vulnerable to cross-site scripting in the move attachment form

### Impact

It’s possible to store JavaScript in an attachment name, which will be executed by anyone trying to move the corresponding attachment.

For example, an attachment with name `>.jpg` will execute the alert.

### Patches
This issue has been patched in XWiki 14.4RC1.

### Workarounds
It is possible to fix the vulnerability by copying [moveStep1.vm](https://raw.githubusercontent.com/xwiki/xwiki-platform/xwiki-platform-14.0-rc-1/xwiki-platform-core/xwiki-platform-attachment/xwiki-platform-attachment-api/src/main/resources/templates/attachment/moveStep1.vm) to `webapp/xwiki/templates/moveStep1.vm` and replace

“`
#set($titleToDisplay = $services.localization.render(‘attachment.move.title’,
[$attachment.name, $escapetool.xml($doc.plainTitle), $doc.getURL()]))
“`

by

“`
#set($titleToDisplay = $services.localization.render(‘attachment.move.title’, [
$escapetool.xml($attachment.name),
$escapetool.xml($doc.plainTitle),
$escapetool.xml($doc.getURL())
]))
“`

See the corresponding [patch](https://github.com/xwiki/xwiki-platform/commit/fbc4bfbae4f6ce8109addb281de86a03acdb9277).

### References

– https://jira.xwiki.org/browse/XWIKI-19667

### For more information

If you have any questions or comments about this advisory:

– Open an issue in [Jira XWiki.org](https://jira.xwiki.org/)
– Email us at [Security Mailing List](mailto:security@xwiki.org)Read More

Exit mobile version